Linux hardware acceleration build fixes #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
hw_acceleration_build
branch
3 times, most recently
from
d03901a to
b69e0d1
Compare
Remove the use_vaapi and use_nvidia Cargo features. Instead: Always require libva on x86 Linux, checked with pkg-config. If cuda.h exists, build with NVidia hardware acceleration support. If you don't have an NVidia GPU, you probably don't want to install a large proprietary driver. The only reason to have the CUDA Toolkit installed if you don't have an NVidia GPU is if you're building a binary that might be used on machines with an NVidia GPU. Also, allow specifying a non-default path for the CUDA Toolkit with the CUDA_HOME environment variable.
Be-ing
force-pushed
the
hw_acceleration_build
branch
from
b69e0d1 to
7b1e4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use_vaapi and use_nvidia Cargo features. Instead:
Always require libva on x86 Linux, checked with pkg-config.
If cuda.h exists, build with NVidia hardware acceleration support. If you don't have an NVidia GPU, you probably don't want to install a large proprietary driver. The only reason to have the CUDA Toolkit installed if you don't have an NVidia GPU is if you're building a binary that might be used on machines with an NVidia GPU.
Also, allow specifying a non-default path for the CUDA Toolkit with the CUDA_HOME environment variable.